Re: [tip:core/rcu] rcu: Remove inline from forward-referencedfunctions

From: Joe Perches
Date: Tue Nov 10 2009 - 17:38:38 EST


On Tue, 2009-11-10 at 22:27 +0000, tip-bot for Paul E. McKenney wrote:
> rcu: Remove inline from forward-referenced functions
> diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
> index ef2a58c..c03edf7 100644
> --- a/kernel/rcutree_plugin.h
> +++ b/kernel/rcutree_plugin.h
> @@ -33,7 +33,7 @@ DEFINE_PER_CPU(struct rcu_data, rcu_preempt_data);
> /*
> * Tell them what RCU they are running.
> */
> -static inline void rcu_bootup_announce(void)
> +static void rcu_bootup_announce(void)
> {
> printk(KERN_INFO
> "Experimental preemptable hierarchical RCU implementation.\n");
> @@ -481,7 +481,7 @@ void exit_rcu(void)
> /*
> * Tell them what RCU they are running.
> */
> -static inline void rcu_bootup_announce(void)
> +static void rcu_bootup_announce(void)
> {
> printk(KERN_INFO "Hierarchical RCU implementation.\n");
> }

non-inline functions in .h files probably aren't a good idea.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/