Re: [PATCH] vt: make the default cursor shape configurable

[David Newall]

Daniel Mack wrote:
> On Tue, Nov 10, 2009 at 04:28:03AM +1030, David Newall wrote:
>   
>> Daniel Mack wrote:
>>     
>>> And even if the cursor behaviour is changable at runtime, I don't see
>>> why it shouldn't have a selectable compile time default. Which is what
>>> the patch adds.
>>>       
>> It seems like adding cruft to the kernel that is just as effectively
>> available at run-time. Where does it end? Do we eventually add bash to
>> the kernel?
>>     
>
> One more thing:
>
> Clemens' last patch didn't add anything to the kernel's binary size.
> It didn't slow down anything either, as there is no run-time condition
> evaluation. It just makes something configurable which was hard
> coded before. So where's the cruft?
>   

In this case the cruft is yet more kernel configuration choices to
confuse and bewilder. The problems caused by cruft are more from its
accretion than from any single part of it. Being able to argue that a
crufty feature causes no change to speed or size misses that point.

Everything should be in the kernel, except those things that don't need
to be (with apologies to Enstein).

I'm having trouble seeing a flashing cursor during device startup as a
problem. I expect it will prove a useful diagnostic, one day. I think
you can turn it off (from user space) within a couple of seconds of
power on; you did say embedded, didn't you? Perhaps you even can
configure your hardware to not display the cursor on startup, which is
the second likeliest (after user-space) place to satisfy your needs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/