Re: [PATCH RESENT] [RTC] Add Freescale MC13783 RTC driver

[Alessandro Zummo]

On Tue, 10 Nov 2009 09:32:47 +0100
Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:

> +	ret = mc13783_irq_request_nounmask(priv->mc13783, MC13783_IRQ_1HZ,
> +			mc13783_rtc_update_handler, DRIVER_NAME, priv);
> +	if (ret)
> +		goto err_update_irq_request;
> +
> +	mc13783_unlock(priv->mc13783);
> +
> +	priv->rtc = rtc_device_register(pdev->name,
> +			&pdev->dev, &mc13783_rtc_ops, THIS_MODULE);
> +

 isn't better to enable irqs after registration?

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/