Re: [BUGFIX][PATCH] oom-kill: fix NUMA consraint check with nodemask v2

From: KOSAKI Motohiro
Date: Tue Nov 10 2009 - 02:39:12 EST


> > > +
> > > + /* Check this allocation failure is caused by cpuset's wall function */
> > > + for_each_zone_zonelist_nodemask(zone, z, zonelist,
> > > + high_zoneidx, nodemask)
> > > + if (!cpuset_zone_allowed_softwall(zone, gfp_mask))
> > > return CONSTRAINT_CPUSET;
> >
> > If cpuset and MPOL_BIND are both used, Probably CONSTRAINT_MEMORY_POLICY is
> > better choice.
>
> No. this memory allocation is failed by limitation of cpuset's alloc mask.
> Not from mempolicy.

But CONSTRAINT_CPUSET doesn't help to free necessary node memory. It isn't
your fault. original code is wrong too. but I hope we should fix it.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/