Re: [PATCH v3] x86: under bios control, restore AP's APIC_LVTTHMR tothe BSP value

[Ingo Molnar]

* Yong Wang <yong.y.wang@xxxxxxxxxxxxxxx> wrote:

> Changes since v2:
> Incorporate Ingo's comments to get BSP's thermal init value in a
> 'boot-CPU-only' function.

> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index e09f0e2..2323771 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -1002,6 +1002,7 @@ void __init setup_arch(char **cmdline_p)
>  
>  	init_apic_mappings();
>  	ioapic_init_mappings();
> +	get_bsp_lvtthmr_init();
>  
>  	/* need to wait for io_apic is mapped */
>  	probe_nr_irqs_gsi();

Ok - it's almost good in this form - it would be nice to name the new 
function something more generic, like mcheck_intel_therm_init(), and 
call it from arch/x86/kernel/cpu/mcheck/mce.c's mcheck_init() function.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/