Re: [PATCH] x86, therm: Only read the initial value of thermal LVTentry on BSP

From: Yong Wang
Date: Sun Nov 08 2009 - 08:05:03 EST


On Sun, Nov 08, 2009 at 11:25:21AM +0100, Ingo Molnar wrote:
>
> i dont disagree with the fix, but could we please do it a bit cleaner,
> and initialize a proper file-scope lvtthrm_init value from a different
> boot-CPU-only function? (not intel_init_thermal)
>

Thanks for your comments. Just want to make sure I understand correctly.
By 'file-scope', do you want me to define lvtthrm_init as a static
variable but not to define it in any function?

> that makes it cleaner, and also it will work if we dont boot on cpu==0.
> (should that ever occur)
>

May I know when will this happen?

Thanks
-Yong
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/