Re: [PATCH] slqb: A not quite so trivial warning

From: Pekka Enberg
Date: Sun Nov 08 2009 - 06:39:27 EST


Hi Alan,

Alan Cox wrote:
mm/slqb.c:2773: warning: initialization from incompatible pointer type

Variable scope...

Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>

I don't see this warning in my tree. Is this coming from linux-next? Did someone change DEFINE_PER_CPU not to prefix the variable name with "per_cpu__"?

Pekka

---

mm/slqb.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)


diff --git a/mm/slqb.c b/mm/slqb.c
index e745d9a..fddcf85 100644
--- a/mm/slqb.c
+++ b/mm/slqb.c
@@ -2770,16 +2770,16 @@ static DEFINE_PER_CPU(struct delayed_work, cache_trim_work);
static void __cpuinit start_cpu_timer(int cpu)
{
- struct delayed_work *cache_trim_work = &per_cpu(cache_trim_work, cpu);
+ struct delayed_work *lcache_trim_work = &per_cpu(cache_trim_work, cpu);
/*
* When this gets called from do_initcalls via cpucache_init(),
* init_workqueues() has already run, so keventd will be setup
* at that time.
*/
- if (keventd_up() && cache_trim_work->work.func == NULL) {
- INIT_DELAYED_WORK(cache_trim_work, cache_trim_worker);
- schedule_delayed_work_on(cpu, cache_trim_work,
+ if (keventd_up() && lcache_trim_work->work.func == NULL) {
+ INIT_DELAYED_WORK(lcache_trim_work, cache_trim_worker);
+ schedule_delayed_work_on(cpu, lcache_trim_work,
__round_jiffies_relative(HZ, cpu));
}
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/