Re: [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc driver inat91sam9g45 chip and board

From: Haavard Skinnemoen
Date: Sat Nov 07 2009 - 06:20:25 EST

Ben Nizette <bn@xxxxxxxxxxxxxxx> wrote:
> On Tue, 2009-11-03 at 15:30 +1300, Ryan Mallon wrote:
> > >
> > IIRC, we can't mark static inline functions as weak, and we don't want
> > to turn gpio_is_valid into an actual function call. We could do some
> > preprocessor magic, but that gets a bit messy.
> Messy but generally accepted.

IIRC the most generally accepted way is to do

static inline bool gpio_is_valid(int pin)
/* whatever */
#define gpio_is_valid gpio_is_valid

in the platform code and

#ifndef gpio_is_valid
/* provide definition of gpio_is_valid */

in the generic code. This way, there's only one symbol to grep for.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at