Re: [PATCH -mm] char, moxa: Make isabrds variable global.

From: Jiri Slaby
Date: Sat Nov 07 2009 - 05:27:03 EST


On 11/07/2009 06:08 AM, Rakib Mullick wrote:
> On 11/3/09, Rakib Mullick <rakib.mullick@xxxxxxxxx> wrote:
>> When CONFIG_MODULE=n and CONFIG_PCI=n, then variable
>> isabrds becomes unused variable. So place it outside
>> moxa_init solves this problem.
>>
>> We were warned by the following warning:
>>
>> drivers/char/moxa.c: In function `moxa_init':
>> drivers/char/moxa.c:1012: warning: unused variable `isabrds'
>
> Hi Andrew, after applying this one, it introduce a new warning:

Sorry I had no time to look into the first patch. And it makes no sense.
The driver is unusable on !MODULE && !PCI. So better fix is to disallow
whole build on such configurations. Care to fix that?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/