Re: [PATCH 20/20] blkio: Drop the reference to queue once the taskchanges cgroup

[Vivek Goyal]

On Wed, Nov 04, 2009 at 02:09:40PM -0500, Jeff Moyer wrote:
> Vivek Goyal <vgoyal@xxxxxxxxxx> writes:
> 
> > o If a task changes cgroup, drop reference to the cfqq associated with io
> >   context so that upon next request arrival we will allocate a  new queue in
> >   new group.
> 
> You're doing more than dropping the reference, you're also setting the
> pointer in the cic to NULL.  This is what you need to do, of course, but
> your changelog is misleading (and sounds incomplete, and sends off
> alarms in my head).
> 

Will enrich changelog in next version.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/