Re: [PATCH 15/20] blkio: Take care of preemptions across groups

From: Jeff Moyer
Date: Wed Nov 04 2009 - 14:01:41 EST


Vivek Goyal <vgoyal@xxxxxxxxxx> writes:

> +static bool cfq_should_preempt_group(struct cfq_data *cfqd,
> + struct cfq_queue *cfqq, struct cfq_queue *new_cfqq)
> +{
> + struct cfq_entity *cfqe = &cfqq->entity;
> + struct cfq_entity *new_cfqe = &new_cfqq->entity;
> +
> + if (cfqq_to_cfqg(cfqq) != &cfqd->root_group)
> + cfqe = parent_entity(&cfqq->entity);
> +
> + if (cfqq_to_cfqg(new_cfqq) != &cfqd->root_group)
> + new_cfqe = parent_entity(&new_cfqq->entity);
> +
> + /*
> + * Allow an RT request to pre-empt an ongoing non-RT cfqq timeslice.
> + */
> +
> + if (new_cfqe->ioprio_class == IOPRIO_CLASS_RT
> + && cfqe->ioprio_class != IOPRIO_CLASS_RT)
> + return true;
> + /*
> + * Allow an BE request to pre-empt an ongoing IDLE clas timeslice.
> + */
> +
> + if (new_cfqe->ioprio_class == IOPRIO_CLASS_BE
> + && cfqe->ioprio_class == IOPRIO_CLASS_IDLE)
> + return true;
> +
> + return false;
> +}

What was the motivation for this? It seems like this would really break
isolation. What if one group has all RT priority tasks, will it starve
out the other groups?

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/