Re: [PATCH 05/10] kbuild: sort the list of symbols exported by thekernel (__ksymtab)

From: Alan Jenkins
Date: Wed Nov 04 2009 - 05:00:59 EST

Rusty Russell wrote:
On Tue, 3 Nov 2009 08:36:17 pm Alan Jenkins wrote:
+ * We use CPP macros since they are more familiar than assembly macros.
+ * Note that CPP macros eat newlines, so each statement must be terminated
+ * by a semicolon.
+ */
+#define __SYM(sym) _##sym
+#define __SYM(sym) sym

Ideally, you would used MODULE_SYMBOL_PREFIX here, but of course it's a
string. I don't think Kconfig can do arbitrary identifiers, so we can't
make CONFIG_SYMBOL_PREFIX empty or _.

Perhaps clarify it to a bool CONFIG_HAVE_MODULE_UNDERSCORE_PREFIX then,
since that's what you're assuming here?


I made the same assumption in patch 4. The arch defines CONFIG_HAVE_SYMBOL_PREFIX, which then causes init/Kconfig to define CONFIG_SYMBOL_PREFIX="_".

Mike suggested that I hack kbuild instead, to do something like

unquote = ...
AFLAGS_.tmp_export-asm.o += -DSYMBOL_PREFIX=$(unquote CONFIG_SYMBOL_PREFIX)

I'm experimenting with the idea, but I haven't managed to get it working yet.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at