Re: [PATCH 5/14] cpumask: use modern cpumask style in drivers/edac/amd64_edac.c

From: Rusty Russell
Date: Wed Nov 04 2009 - 03:03:21 EST


On Tue, 3 Nov 2009 05:13:47 pm Borislav Petkov wrote:
> Hi,
>
> On Tue, Nov 03, 2009 at 02:56:35PM +1030, Rusty Russell wrote:
> > cpumask_t -> struct cpumask, and don't put one on the stack. (Note: this
> > is actually on the stack unless CONFIG_CPUMASK_OFFSTACK=y).
> >
> > Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>
> I've got a similar patch already queued up but it
> depends on the changes to rdmsr_on_cpus/wrmsr_on_cpus in
> b8a4754147d61f5359a765a3afd3eb03012aa052 which is in tip/x86/cpu and
> which does a bit more than your patch 4 so IMHO you could drop yours.
>
> Concerning the edac change, yours is better and I could pick it up and
> add it to my patch queue if nobody else has a problem with that?

Less work for me sounds *excellent*.

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/