Re: [PATCH] qlogicpti: add missing parentheses
From: David Miller
Date: Tue Nov 03 2009 - 19:18:52 EST
From: James Bottomley <James.Bottomley@xxxxxxx>
Date: Tue, 03 Nov 2009 17:51:49 -0600
> On Wed, 2009-11-04 at 00:38 +0100, Roel Kluin wrote:
>> `+' has a higher precedence than `?' so the condition always
>> evaluates to true and this is preprocessed to `7*((ql) - 1)'
>> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
>> drivers/scsi/qlogicpti.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> This one must be right, I think.
> It looks plausible ... but it will increase the mailbox segment length
> by 4 ... someone needs to verify that this increase will actually work
> and won't run off the end of the mailbox table.
It should be fine, good find Roel.
Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/