Re: Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344

From: Zdenek Kabelac
Date: Tue Nov 03 2009 - 10:54:50 EST

2009/11/3 Marcel Holtmann <marcel@xxxxxxxxxxxx>:
> Hi Linus,
>> > and can we please stop jumping the gun here and going past the subsystem
>> > maintainers. I think this happens a little bit too much lately.
>> NO!
>> Quite frankly, I'm very unhappy indeed with the maintainers when it comes
>> to this bug:
>>  - it was introduced after -rc5
>>  - it's been bisected by multiple people
>>  - I've seen one of the encounters with a person who bisected it, and the
>>    author of the buggy commit just wanted "more information" after having
>>    been told that small commit causes lockups.
>> In other words - the LAST thing we should do is to pat the subsystem
>> maintainers on the back and say "good job".
>> The fact is, when somebody reports a major bug that is fixed by a revert,
>> then I shoudl probably revert _more_ eagerly rather than less!
>> And subsystem maintainers should jump on it, not wait several days.
> no questions that it needs fixed, I agree with you. However just blindly
> reverting something, because it fixes it for one or two people, might
> have side effects that causes more problems than the revert would
> actually fix. In this case, let at least give John or Johannes a chance
> to comment on it.
> I do love the fact that it gets bisected down to one particular commit.
> That is great and thanks to the people who did that, but let the
> subsystem maintainers know and then have them either provide a fix or
> revert it by them. Sometimes it might take more than one day. And lets
> be honest here, Johannes is one of the most responsive persons when it
> comes to wireless bugs.
> Regards

Well for me the issue has been fixed by

But it was not easy to decrypt bug after resume in my case....

However doing commit of memcpy where the src could be NULL in -rc5
looks really suspicious.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at