Re: [RFC][PATCH 1/7] Adding general performance benchmarkingsubsystem to perf.

[Ingo Molnar]

* Hitoshi Mitake <mitake@xxxxxxxxxxxxxxxxxxxxx> wrote:

> 
> Adding general performance benchmarking subsystem to perf.
> This patch modifies Makefile of perf to build new source files.
> 
> Signed-off-by: Hitoshi Mitake <mitake@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Mike Galbraith <efault@xxxxxx>
> ---
>  tools/perf/Makefile |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 7e190d5..f6f7a6b 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -391,6 +391,9 @@ BUILTIN_OBJS += builtin-stat.o
>  BUILTIN_OBJS += builtin-timechart.o
>  BUILTIN_OBJS += builtin-top.o
>  BUILTIN_OBJS += builtin-trace.o
> +BUILTIN_OBJS += builtin-bench.o
> +BUILTIN_OBJS += builtin-bench-messaging.o
> +BUILTIN_OBJS += builtin-bench-pipe.o

The series should be bisectable (i.e. build at every step) - so i'd 
suggest to add this Makefile bit to the patch that adds the .c, or move 
the .c addition before the Makefile addition patch.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/