RE: [PATCH 1/1] PM: Making bdi threads non-freezable
From: Dasgupta, Romit
Date: Tue Nov 03 2009 - 01:42:49 EST
> Subject: Re: [PATCH 1/1] PM: Making bdi threads non-freezable
> On Monday 02 November 2009, Dasgupta, Romit wrote:
> > Fixes the case when bdi threads are in the refrigerator but file system sync
> > can happen after this. This is possible in MMC when
> CONFIG_MMC_UNSAFE_RESUME is
> > not set.
> What's going to happen if we attemt to suspend the underlying block device(s)
> when the bdi thread are doing their job? Is there any synchronisation
> mechanism for that?
There is no explicit synchronization AFAICT. However, it looks like the call to 'del_gendisk' would invoke 'sync_filesystem' down the line. 'sync_filesystem' would end with synchronous writes of inodes followed by a call to '__sync_blockddev'.
After this call I believe there should not be any activity pending for the blockdevice. So this should not lead to any race. My tests on the development board did not show any issues. But some FS experts may comment.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/