Re: [PATCH] input: fix locking context in ml_ff_set_gain

From: Arjan van de Ven
Date: Tue Nov 03 2009 - 00:52:48 EST

> OK, it ended up being pretty simple. Anssi, any chance you could test
> it to make sure I did not screw up? Thanks!
@@ -371,35 +370,34 @@ static void ml_effect_timer(unsigned long
debug("timer: updating effects");

- spin_lock(&ml->timer_lock);
+ spin_lock_irq(&dev->event_lock);
- spin_unlock(&ml->timer_lock);
+ spin_unlock_irq(&dev->event_lock);

this bit looks evil.

might be better off as irqsave...

Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at