Re: [patch 18/28] watchdog: Remove BKL from rio watchdog driver

From: David Miller
Date: Tue Nov 03 2009 - 00:16:26 EST

From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Date: Sat, 10 Oct 2009 15:36:48 -0000

> cycle_kernel_lock() was added with the BKL pushdown. The rio driver
> indeed needs that because riowd_device is initialized after
> misc_register(). So an open(), write/ioctl() which happens to get
> between misc_register returning and riowd_device initialization would
> dereference a NULL pointer.
> Move riowd_device initialization before misc_register() and get rid of
> cycle_kernel_lock().
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Also applied to sparc-next-2.6, thanks!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at