Re: [PATCH 02/11] Add "handle page fault" PV helper.
From: Avi Kivity
Date: Mon Nov 02 2009 - 14:34:09 EST
On 11/02/2009 09:03 PM, Rik van Riel wrote:
This patch is not acceptable unless it's done cleaner. Currently we
already have 3 callbacks in do_page_fault() (kmemcheck, mmiotrace,
notifier), and this adds a fourth one.
There's another alternative - add our own exception vector
for async page faults. Not sure if that is warranted though,
especially if we already have other callbacks in do_page_fault()
and we can consolidate them.
We can't add an exception vector since all the existing ones are either
taken or reserved. We can try to use an interrupt vector as an
exception, but that becomes messy, and I'm not sure hardware will allow
us to inject an interrupt when interrupts are disabled.
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/