Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

From: Nicolas Pitre
Date: Mon Nov 02 2009 - 12:52:52 EST


On Mon, 2 Nov 2009, Alan Cox wrote:

> This sorts out the sdio uart handling of the tty layer. The existing code
> has lots of races and other fun bugs. Beat it into the current tty format for
> hotpluggable devices. The updates are intentionally modelled on Alan Stern's
> USB serial approach which is defintiely "best practice" right now. Also clean
> it up as we go and sort the circ stuff out.

Thanks.

> I don't have hardware to test this so hopefully someone out there does,
> otherwise given the nature of the bugs involved the driver will be progressed
> to BROKEN and removal.

I still have the hardware. Even tested it recently with a new SDIO host
controller and it "worked just fine". Hardware is a GPS receiver so
admitedly nothing that would push this driver into corner cases.

However I have problems applying your patches. Most of them require
fuzzy patching to apply, and one of them even doesn't apply that way.
What is your base tree?


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/