Re: [PATCH] pci: remove pci_find_slot from PCI_LEGACY configdescription
From: Thadeu Lima de Souza Cascardo
Date: Mon Nov 02 2009 - 11:56:19 EST
On Mon, Nov 02, 2009 at 04:49:01PM +0100, Jiri Kosina wrote:
> On Fri, 30 Oct 2009, Thadeu Lima de Souza Cascardo wrote:
> > Commit 3b073eda has removed pci_find_slot, so there's no point in
> > mentioning it in the config description as one of the deprecated APIs
> > there are enabled by PCI_LEGACY and still used by some drivers.
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx>
> > ---
> > drivers/pci/Kconfig | 8 ++++----
> > 1 files changed, 4 insertions(+), 4 deletions(-)
> > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> > index fdc864f..48a3ea7 100644
> > --- a/drivers/pci/Kconfig
> > +++ b/drivers/pci/Kconfig
> > @@ -27,10 +27,10 @@ config PCI_LEGACY
> > default y
> > help
> > Say Y here if you want to include support for the deprecated
> > - pci_find_slot() and pci_find_device() APIs. Most drivers have
> > - been converted over to using the proper hotplug APIs, so this
> > - option serves to include/exclude only a few drivers that are
> > - still using this API.
> > + pci_find_device() API. Most drivers have been converted over
> > + to using the proper hotplug APIs, so this option serves to
> > + include/exclude only a few drivers that are still using this
> > + API.
> While you are at it, how about removing the references in
> Documentation/PCI/pci.txt as well?
> Jiri Kosina
> SUSE Labs, Novell Inc.
I've hit them. But, on a first fast look, they seemed important
historically. I will take a closer look and point that if it's proper or
remove them entirely as you suggest.
Description: Digital signature