Re: [PATCH] mfd/mc13783: near complete rewrite

From: Mark Brown
Date: Mon Nov 02 2009 - 10:12:49 EST

On Mon, Nov 02, 2009 at 03:32:29PM +0100, Uwe Kleine-König wrote:

> On mc13783 the 1HZ irq triggers immediately after unmasking provided
> that it has power for more than 1s. Because of locking the irq isn't
> recognized as 1HZ as the irqhandler tries to take the lock that the rtc
> probe function is holding and only releasing after the irq is masked.
> So for me it's just a spurious irq.

Hrm, I can't see that in the RTC driver code? I'd have expected that if
there is a lock it'd ensure that the handler is in place before the
interrupt is unmasked.

Looking at the IRQ handler I do notice that you require all the handlers
to explicitly ack their interrupts - are there circumstances where a
handler wouldn't want to do the ack? If there aren't it'd seem like
it'd save work to have the core driver do the acks.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at