Re: [PATCH 5/8] drivers/media/video/uvc: Use %pUl to print UUIDs

From: Laurent Pinchart
Date: Sat Oct 31 2009 - 15:10:45 EST


On Saturday 31 October 2009 10:07:01 Mauro Carvalho Chehab wrote:
> Hi Laurent,
>
> Em Mon, 12 Oct 2009 00:34:58 +0200
>
> Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> escreveu:
> > As this will go through the linuxtv v4l-dvb tree, I'll have to add
> > backward compatibility code (that will not make it to mainline). If
> > that's ok with you it will be easier for me to test and apply that part
> > of the patch through my tree once the vsprintf extension gets in.
>
> I'm assuming that those printk patches from Joe to uvc will go via your
> tree, so please submit a pull request when they'll be ready for upstream.

I'll submit the pull request as soon as the printk core patch hits upstream.

The change will break the driver when used with older versions (it will
compile, load and run, but will print broken messages), and compat.h
compatibility magic will not be possible. As the messages are purely
informational, I'm pondering not even keeping #ifdef compatibility. Any
thought on that ?

--
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/