Re: [PATCH] x86, apicdef: Fix checkpatch issues in apicdef.h

[Cyrill Gorcunov]

[Rakib Mullick - Sat, Oct 31, 2009 at 03:29:32PM +0600]
|
|  In apicdef.h - we have a checkpatch issue - needs to be fixed.
| We were warned by the following checkpatch warning:
| 
| ERROR: space prohibited before that ':' (ctx:WxW)
| #276: FILE: arch/x86/include/asm/apicdef.h:376:
| +                       hi      : 1;
|                                 ^
| ---
| Signed-off-by: Rakib Mullick <rakib.mullick@xxxxxxxxx>
| 

Hi Rakib,

personally I would not change it even having checkpatch
issue. Really, it's easier to read this bitfield width
aligned rather then moved left. But this is a personal
opinion only (sorry).

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/