Re: [patch 3/3] x86_64, cpa: use only text section inset_kernel_text_rw/ro

From: Steven Rostedt
Date: Fri Oct 30 2009 - 15:59:08 EST


On Fri, 2009-10-30 at 11:17 -0800, Suresh Siddha wrote:
> On Wed, 2009-10-28 at 19:06 -0700, Steven Rostedt wrote:
> > On Wed, 2009-10-28 at 18:46 -0800, Suresh Siddha wrote:
> > > plain text document attachment (fix_kernel_text_ro_rw.patch)
> > > set_kernel_text_rw()/set_kernel_text_ro() are marking pages starting
> > > from _text to __start_rodata as RW or RO.
> > >
> > > With CONFIG_DEBUG_RODATA, there might be free pages (associated with
> > > padding the sections to 2MB large page boundary) between text
> > > and rodata sections that are given back to page allocator. So we should
> > > use only use the start (__text) and end (__stop___ex_table) of the
> > > text section in set_kernel_text_rw()/set_kernel_text_ro().
> > >
> > > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > > Signed-off-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>
> > > ---
> > >
> >
> > I'll go ahead and test this to make sure it does not bust ftrace with an
> > allyesconfig.
>
> Steve, Good to go?

Yep. Sorry, during the testing I hit the jprobe vs function graph bug
and got distracted. But as for this patch set ...

Tested-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

Thanks,

-- Steve

>
> If so, Ingo can you please consider this patchset?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/