Re: [PATCH] RFC: futex: make futex_lock_pi interruptible

From: Chris Friesen
Date: Fri Oct 30 2009 - 13:59:09 EST


On 10/29/2009 07:45 PM, Darren Hart wrote:

> This appears to work fine. Can anyone think of a reason why this is an unsafe
> thing to do? I'll have to create a much more elaborate test case and review
> the glibc code of course to make sure the glibc mutex state isn't compromised.

Setting aside the specific code details, I would suggest that you not
review the glibc code but rather review the glibc documentation and the
susv3/posix specifications. That way, if it behaves according to the
spec but breaks glibc you can push for a patch to glibc.

If it happens to work with current glibc but is not standards-compliant,
then it could break in the future.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/