Re: [PATCH][RE-SUBMIT] Default setting of the ARM_UNWIND option

From: Claudio Scordino
Date: Fri Oct 30 2009 - 07:11:54 EST


Hi,

I modified the patch according to your suggestions.


You can just send it to Russell's patch system once there are no more
comments on it.

Done. I'm attaching the latest version here too.

Many thanks,

Claudio From: Claudio Scordino <claudio@xxxxxxxxxxxxxxx>
Date: Fri, 30 Oct 2009 11:46:00 +0100
Subject: [PATCH 1/1] ARM unwind is known to compile only with EABI and not-buggy compilers.

ARM unwind is known to compile only with EABI and not-buggy compilers.
The problem is not the unwinding information but the -fno-frame-pointer option added as a result of !CONFIG_FRAME_POINTER.
Now we check the compiler and raise a #warning in case of wrong compiler.


Signed-off-by: Claudio Scordino <claudio@xxxxxxxxxxxxxxx>
---
arch/arm/kernel/unwind.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c
index 39baf11..786ac2b 100644
--- a/arch/arm/kernel/unwind.c
+++ b/arch/arm/kernel/unwind.c
@@ -26,6 +26,15 @@
* http://infocenter.arm.com/help/topic/com.arm.doc.subset.swdev.abi/index.html
*/

+#if !defined (__ARM_EABI__)
+#warning Your compiler does not have EABI support.
+#warning ARM unwind is known to compile only with EABI compilers.
+#warning Change compiler or disable ARM_UNWIND option.
+#elif (__GNUC__ == 4 && __GNUC_MINOR__ <= 2)
+#warning Your compiler is too buggy; it is known to not compile ARM unwind support.
+#warning Change compiler or disable ARM_UNWIND option.
+#endif
+
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/module.h>
--
1.6.0.4