Re: [PATCH 1/3] Fix updating of named attribute groups

[Tejun Heo]

Matthew Wilcox wrote:
> +		if (update) {
> +			sd = sysfs_get_dirent(kobj->sd, grp->name);
> +			if (!sd)
> +				return -ENOENT;
> +		} else {
> +			error = sysfs_create_subdir(kobj, grp->name, &sd);
> +			if (error)
> +				return error;
> +			sysfs_get(sd);
> +		}
> +	} else {
> +		sd = sysfs_get(kobj->sd);
> +	}

nitpick: the last braces aren't necessary.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/