Re: [PATCH] perf tools: Delay loading symtabs till we hit a mapwith it

From: Ingo Molnar
Date: Thu Oct 29 2009 - 03:24:54 EST


* Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxx> wrote:

> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
> So that we can have a quicker start on perf top and even speedups in the
> other tools, as we can have maps with no hits, so no need to load its
> symtabs.
>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Mike Galbraith <efault@xxxxxx>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> ---
> tools/perf/builtin-annotate.c | 4 ++--
> tools/perf/builtin-report.c | 4 ++--
> tools/perf/builtin-top.c | 5 ++---
> tools/perf/util/event.h | 4 +++-
> tools/perf/util/map.c | 40 ++++++++++++++++++++++++----------------
> tools/perf/util/symbol.c | 16 +++++++++-------
> tools/perf/util/symbol.h | 4 ++--
> 7 files changed, 44 insertions(+), 33 deletions(-)

ok, that's a really nice feature - i noticed the occasional symtab
loading overhead in tools.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/