Re: [PATCH] serial: copy UART properties of UPF_FIXED_TYPE portsprovisioned using early_serial_setup

[Andrew Morton]

On Mon, 26 Oct 2009 12:50:07 +0200 Shmulik Ladkani <shmulik@xxxxxxxxx> wrote:

> Augment the UPF_FIXED_TYPE logic, which currently applies to UART ports 
> provisioned using platform_device_register.
> 
> The suggested patch applies same logic into 'serial8250_register_ports', 
> making UART ports provisioned using early_serial_setup inherit their 
> properties from the uart_config entry.
> 
> The patch applies to linux-2.6.32-rc5
> 
> Signed-off-by: Shmulik Ladkani <shmulik@xxxxxxxxx>
> ---
> diff -upr linux-2.6.32-rc5.clean/drivers/serial/8250.c 
> linux-2.6.32-rc5/drivers/serial/8250.c
> --- linux-2.6.32-rc5.clean/drivers/serial/8250.c	2009-10-16 
> 02:41:50.000000000 +0200
> +++ linux-2.6.32-rc5/drivers/serial/8250.c	2009-10-26 11:36:09.000000000 
> +0200

Your email client wordwraps the patches.

> @@ -2704,6 +2704,14 @@ serial8250_register_ports(struct uart_dr
>   		struct uart_8250_port *up = &serial8250_ports[i];
> 
>   		up->port.dev = dev;
> +
> +		if (up->port.flags & UPF_FIXED_TYPE) {
> +			up->port.fifosize =
> +				uart_config[up->port.type].fifo_size;
> +			up->capabilities = uart_config[up->port.type].flags;
> +			up->tx_loadsz = uart_config[up->port.type].tx_loadsz;
> +		}
> +
>   		uart_add_one_port(drv, &up->port);
>   	}
>   }

Why don't we also initialise up->port.type here?

Perhaps it would be neater to write a little function to do this rather
than copy-n-paste?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/