Re: [patch] Re: Zillions of warnings in -next
From: Gregory Haskins
Date: Wed Oct 28 2009 - 09:36:15 EST
Randy Dunlap wrote:
> On Tue, 27 Oct 2009 22:21:12 +0000 Alan Cox wrote:
>
>>> I just did a 32-bit build and indeed reproduced the warnings. However, the warnings
>>> appear to be dubious as the code is properly (afaict) annotated with explicit casts, and
>>> I believe they are doing what I intended.
>>>
>>> Basically I have structures that are always 64 bit (so we can have a mixed-mode 32-bit
>>> guest talk to a 64-bit hypervisor, for instance). Therefore I am casting between native
>>> and u64, but the compiler doesn't like this. Does anyone have any suggestions on ways
>>> to fix this so the compiler is happy?
>> foo = (void *)(unsigned long)x
>>
>> works for the general case because Linux assumes ptr fits ulong
>>
>> Similarly in the other direction.
Thank you, Alan. Your tip was spot on.
>
> Yes, I already had this done for venet and pci-bridge. Patch below.
>
> ---
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> Eliminate all cast warnings in vbus-enet.c and pci-bridge.c.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Thank you, Randy. Applied.
Kind Regards,
-Greg
Attachment:
signature.asc
Description: OpenPGP digital signature