Re: is avoiding compat ioctls possible?

[Dave Airlie]

> 
> > we already opencoded this (probably before it was macroisied or we just 
> > pasted it), so the radeon one is buggy, I should just go and compat_* all 
> > of these then and we should be all happy?
> 
> It should be, it's only working because:
> 
> 1) A malicious userland hasn't put garbage in the upper bits for
>    you yet.
> 
> 2) Nobody has tested s390 yet :-)
> 

So will an inline like this work?

static inline void *__user convert_user_ptr(uint64_t ioctl_ptr)
{
#ifdef CONFIG_COMPAT
	if (is_compat_task())
		return compat_ptr((compat_uptr_t)ioctl_ptr);
	else
#endif
		return (void __user *)(unsigned long)ioctl_ptr;
}

then I can convert all the code to just use that instead of explicity 
casts or brokenness.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/