Re: [PATCH 1/2] percpu: allow pcpu_alloc() to be called with IRQsoff

From: Tejun Heo
Date: Tue Oct 27 2009 - 08:55:25 EST


Jiri Kosina wrote:
> pcpu_alloc() and pcpu_extend_area_map() perform a series of
> spin_lock_irq()/spin_unlock_irq() calls, which make them unsafe
> with respect to being called from contexts which have IRQs off.
>
> This patch converts the code to perform save/restore of flags instead,
> making pcpu_alloc() (or __alloc_percpu() respectively) to be called
> from early kernel startup stage, where IRQs are off.
>
> This is needed for proper initialization of per-cpu rq_weight data from
> sched_init().
>
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

I'll wait for response on the series and push it through percpu#fixes
tomorrow if there's no objection.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/