Re: [RFC]cfq-iosched: improve hw_tag detection

[Jens Axboe]

On Tue, Oct 27 2009, Shaohua Li wrote:
> On Mon, Oct 26, 2009 at 07:35:55PM +0800, Jens Axboe wrote:
> > On Mon, Oct 26 2009, Shaohua Li wrote:
> > > If active queue hasn't enough requests and idle window opens, cfq will not
> > > dispatch sufficient requests to hardware. In such situation, current code
> > > will zero hw_tag. But this is because cfq doesn't dispatch enough requests
> > > instead of hardware queue doesn't work. Don't zero hw_tag in such case.
> > 
> > Thanks, that looks like a good fix. Curious, is this fixing some
> > regression at your end?
> No, just observed such issue when I play with cfq.

OK thanks, just curious. I will apply it for 2.6.33.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/