Re: [PATCH 1/5] dma: create dma_generic_alloc/free_coherent()

[FUJITA Tomonori]

On Mon, 26 Oct 2009 17:24:58 -0600
Alex Williamson <alex.williamson@xxxxxx> wrote:

> Move dma_generic_alloc_coherent() out of x86 code and create
> corresponding dma_generic_free_coherent() for symmetry.  These
> can then be used by IOMMU drivers attempting to implement
> passthrough mode.
> 
> Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>
> ---
> 
>  arch/x86/include/asm/dma-mapping.h |    3 --
>  arch/x86/kernel/pci-dma.c          |   31 -------------------------
>  arch/x86/kernel/pci-nommu.c        |   10 +++++++-
>  include/linux/dma-mapping.h        |   44 ++++++++++++++++++++++++++++++++++++
>  4 files changed, 52 insertions(+), 36 deletions(-)

dma_generic_alloc_coherent() is x86 specific; other sane architectures
don't need such GFP_ hack. So moving it to the generic place is not a
good idea.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/