Re: [PATCH 6/8] SGI x86_64 UV: Limit the number of microcode messages

[Mike Travis]

Tigran Aivazian wrote:
> On Sat, 24 Oct 2009, Dmitry Adamushko wrote:
> > > -       printk(KERN_INFO "microcode: CPU%d sig=0x%x, pf=0x%x, 
> > > revision=0x%x\n",
> > > +       if (cpu_num < 4 || !limit_console_output(false))
> > > +               printk(KERN_INFO
> > > +                       "microcode: CPU%d sig=0x%x, pf=0x%x, 
> > > revision=0x%x\n",
> > >                        cpu_num, csig->sig, csig->pf, csig->rev);
> >
> > Hmm, I guess we wouldn't lose a lot by simply removing those messages
> > completely. Per-cpu pf/revision is available via /sys anyway.
>
> The reason for printing them is that the pf (possibly others?) can 
> change by the update and so the log has this info handy.
>
> Kind regards
> Tigran

Is there any reason to need this on the console before being able to
look at them with dmesg?  (Or use some filter program to hunt through
the system log?)

And if all the cpus are the same, would the printing of each one give
you any more information?  I could add something that attempts to
print the new line if it's different than the previous, but this would
add complexity, maybe unnecessarily?   And I was going for an approach
that optimizes to zero code when not enabled.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/