Re: [PATCH tip/core/rcu 6/6] rcu: Simplify creating of lockdepclass for root rcu_node

From: Paul E. McKenney
Date: Mon Oct 26 2009 - 13:29:38 EST


On Mon, Oct 26, 2009 at 04:34:10PM +0800, Lai Jiangshan wrote:
> Paul E. McKenney wrote:
> > diff --git a/kernel/rcutree.h b/kernel/rcutree.h
> > index 599161f..e091b30 100644
> > --- a/kernel/rcutree.h
> > +++ b/kernel/rcutree.h
> > @@ -296,6 +296,8 @@ DECLARE_PER_CPU(struct rcu_data, rcu_preempt_data);
> >
> > #else /* #ifdef RCU_TREE_NONCORE */
> >
> > +static struct lock_class_key rcu_root_class;
> > +
>
> I think this line needs to be moved into rcutree.c.

Good point, I will submit a cleanup patch.

> > /* Forward declarations for rcutree_plugin.h */
> > static inline void rcu_bootup_announce(void);
> > long rcu_batches_completed(void);
>
> For all 6 patches:
> Reviewed-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>

Thank you!!!

Thanx, Paul

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/