Re: platform_device_add_data(pdev, NULL, 0)

[Greg KH]

On Fri, Oct 23, 2009 at 10:26:22PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> mfd_add_device() (defined in drivers/mfd/mfd-core.c) is a wrapper do
> allocate platform_devices.
> 
> It contains:
> 
> 	ret = platform_device_add_data(pdev,
> 			cell->platform_data, cell->data_size);
> 
> If cell->data_size is 0 (and so likely cell->platform_data == NULL),
> still pdev->dev.platform_data get assigned ZERO_SIZE_PTR.
> 
> IMHO the result should better be that pdev->dev.platform_data ends being
> NULL, too.  Agreed?

Why?  Is this causing problems somewhere?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/