[PATCH] x86: fix iommu=nodac parameter handling

From: Tejun Heo
Date: Mon Oct 26 2009 - 10:41:59 EST


nodac should forbid dac instead of enabling it. Fix it.

Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
Cc: Matteo Frigo <athena@xxxxxxxx>
Cc: stable@xxxxxxxxxx
---
This was posted several months ago in a two patch series. The second
one was rejected by Alan and with that the first one got lost too
although it's an apparent bug fix. Matteo hit this bug recently and
reminded me about this patch. So, regenerated and reposting.

Thanks.

arch/x86/kernel/pci-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index d20009b..8cf3996 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -216,7 +216,7 @@ static __init int iommu_setup(char *p)
if (!strncmp(p, "allowdac", 8))
forbid_dac = 0;
if (!strncmp(p, "nodac", 5))
- forbid_dac = -1;
+ forbid_dac = 1;
if (!strncmp(p, "usedac", 6)) {
forbid_dac = -1;
return 1;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/