Re: [PATCH] ext2: Avoid WARN() messages when failing to write tothe superblock

[Theodore Tso]

On Sun, Oct 25, 2009 at 07:21:28AM +0100, Pavel Machek wrote:
> > +	if (buffer_write_io_error(sbh)) {
> > +		/*
> > +		 * Oh, dear.  A previous attempt to write the
> > +		 * superblock failed.  This could happen because the
> > +		 * USB device was yanked out.  Or it could happen to
> > +		 * be a transient write error and maybe the block will
> > +		 * be remapped.  Nothing we can do but to retry the
> > +		 * write and hope for the best.
> > +		 */
> > +		printk(KERN_ERR "EXT2-fs: %s previous I/O error to "
> > +		       "superblock detected", sb->s_id);
> 
> KERN_ALERT/KERN_CRITICAL?

Based on kerneloops.org logs, it's apparently very frequent that
clueless lusers rip out USB drives without bothering to unmount them
first.  (Or people by crappy laptops where the SD cards sticks out
slightly and is easily jostled.)  It's not clear we really want to be
issueing KERN_ALERT or KERN_CRITICAL messages when this very common
event happens.

						- TRed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/