Re: [PATCH] clockevents.c: fix symbol was not declared noise

[Yong Zhang]

On Sat, Oct 17, 2009 at 6:19 AM, H Hartley Sweeten
<hartleys@xxxxxxxxxxxxxxxxxxx> wrote:
> Include "tick-internal.h" in order to pick up the extern function
> prototype for clockevents_shutdown(). ÂThis quiets the following
> spares build noise:
>
> Âwarning: symbol 'clockevents_shutdown' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
>

Looks good.
Reviewed-by: Yong Zhang <yong.zhang0@xxxxxxxxx>

Cc'ed some experts.

> ---
>
> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
> index 620b58a..c30ba1f 100644
> --- a/kernel/time/clockevents.c
> +++ b/kernel/time/clockevents.c
> @@ -20,6 +20,8 @@
> Â#include <linux/sysdev.h>
> Â#include <linux/tick.h>
>
> +#include "tick-internal.h"
> +
> Â/* The registered clock event devices */
> Âstatic LIST_HEAD(clockevent_devices);
> Âstatic LIST_HEAD(clockevents_released);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/