Re: [PATCH v7 4/5]: core: Add kernel message dumper to call onoopses and panics
From: Ingo Molnar
Date: Thu Oct 15 2009 - 05:33:13 EST
* Simon Kagstrom <simon.kagstrom@xxxxxxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/include/linux/kmsg_dump.h
> +enum kmsg_dump_reason {
> + kmsg_dump_oops,
> + kmsg_dump_panic,
> +};
Please capitalize constants - lower case suggests it's some sort of
variable which it is not.
> +void dump_kmsg(enum kmsg_dump_reason reason);
> +
> +int register_kmsg_dumper(struct kmsg_dumper *dumper);
> +
> +void unregister_kmsg_dumper(struct kmsg_dumper *dumper);
Please rename these APIs to be more in line with how we name new kernel
APIs. Something like:
kmsg_dump()
kmsg_dumper_register()
kmsg_dumper_unregister()
(we start with the subsystem as a prefix, then we go from more generic
to less generic words.)
Might even make sense to name them all kmsg_dump:
kmsg_dump()
kmsg_dump_register()
kmsg_dump_unregister()
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/