Re: [PATCH] 8250_pci: Add IBM Saturn serial card

From: Benjamin Herrenschmidt
Date: Wed Oct 14 2009 - 17:03:26 EST


On Wed, 2009-10-14 at 12:48 +0100, Alan Cox wrote:
> On Wed, 14 Oct 2009 10:40:53 +1100
> Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > The IBM Saturn serial card has only one port. Without that fixup,
> > the kernel thinks it has two, which confuses userland setup and
> > admin tools as well.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
>
> Looks good to me but can you drop a space between the last DEVICE_ID and
> the VENDOR_ID bit in the header to follow the style ?

Ok. It was between the last IBM device ID and the IBM subvendor, I
wasn't sure if that warranted a blank line :-)

I'll send a new patch from work.

Cheers,
Ben.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/