RE: [PATCH 13/16] percpu: remove per_cpu__ prefix.

[Christoph Lameter]

On Wed, 14 Oct 2009, Luck, Tony wrote:

> But that would leave no visual indicator in the source
> code that a per-cpu variable was being used.  E.g. in
> delayed_tlb_flush() we'd end up with:

we would still have to use per cpu operations to get to the contents of
these variables.
>
>    if (unlikely(ia64_need_tlb_flush)) {

     if (unlikely(this_cpu_read(ia64_need_tlb_flush))
>        spin_lock ...
>        if (ia64_need_tlb_flush) {

	ditto.

>            local_flush_tlb_all();
>            ia64_need_tlb_flush = 0;

		this_cpu_write(ia64_need_tlb_flush, 0);
>        }
>        spin_unlock ...
>    }
>

Hope that addresses your concerns.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/