Re: [tip:bkl/drivers] drivers: Remove BKL from misc_open

From: Thomas Gleixner
Date: Wed Oct 14 2009 - 12:09:22 EST


On Wed, 14 Oct 2009, Arnd Bergmann wrote:
> On Wednesday 14 October 2009, tip-bot for Thomas Gleixner wrote:
> > Commit-ID: 40b798efe3460797a4ac928ee2e038774e2758eb
> > Gitweb: http://git.kernel.org/tip/40b798efe3460797a4ac928ee2e038774e2758eb
> > Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > AuthorDate: Sat, 10 Oct 2009 15:35:43 +0000
> > Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > CommitDate: Wed, 14 Oct 2009 17:33:32 +0200
> >
> > drivers: Remove BKL from misc_open
> >
> > misc_open() is already serialized with misc_mtx. Remove the BKL
> > locking which got there via the BKL pushdown.
>
> Did you check the misc drivers to make sure this is not silently
> removing the BKL from drivers that need it?

Yep, they are plastered with cycle_kernel_lock and lock/unlock_kernel
already. I might have missed some, but ...

Thanks,

tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/