Re: [regression] 2.6.30 leaking keys on console switch
From: Dmitry Torokhov
Date: Wed Oct 14 2009 - 03:51:57 EST
On Wed, Oct 14, 2009 at 12:39:28AM -0700, Dmitry Torokhov wrote:
> On Wed, Oct 14, 2009 at 09:19:50AM +0200, Andi Kleen wrote:
> > > Btw, what kind of keyboard is this? I was playing today but I could not
> > > get my USB keyboards to report release of more than 1 key per report....
> >
> > The log was with a PS/2<->USB adapter, with a PS/2 keyboard connected
> > to a USB port through it.
> >
>
> Hmm, I don't think I have one of those... It is curious beast - we have
> software autorepeat for HID but PS/2 keyboards do autorepeat
> themselves... What will combination do?
>
Could you please try this incredibly stupid patch?
--
Dmitry
Input: autorepeat debug patch
From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
---
drivers/input/input.c | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 6ba676b..77fa3da 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -137,7 +137,7 @@ static void input_repeat_key(unsigned long data)
if (test_bit(dev->repeat_key, dev->key) &&
is_event_supported(dev->repeat_key, dev->keybit, KEY_MAX)) {
- input_pass_event(dev, EV_KEY, dev->repeat_key, 2);
+ input_pass_event(dev, EV_KEY, dev->repeat_key, 200);
if (dev->sync) {
/*
@@ -208,7 +208,15 @@ static void input_handle_event(struct input_dev *dev,
if (is_event_supported(code, dev->keybit, KEY_MAX) &&
!!test_bit(code, dev->key) != value) {
- if (value != 2) {
+ if (value == 2 || value == 200) {
+ /* autorepeat */
+ if (!test_bit(code, dev->key)) {
+ printk(KERN_ERR "%s autorepeat for released key %d\n",
+ value == 200 ? "software" : "hardware", code);
+ break;
+ }
+ value = 2;
+ } else {
__change_bit(code, dev->key);
if (value)
input_start_autorepeat(dev, code);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/