Re: [PATCH 1/3] edac: Create an unique instance for each kobj

[Andrew Morton]

On Sun, 4 Oct 2009 16:43:54 -0300 Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote:

> Current code only works when there's just one memory
> controller, since we need one kobj for each instance.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> ---
>  drivers/edac/edac_core.h     |   21 ++++++++---
>  drivers/edac/edac_mc_sysfs.c |   75 +++++++++++++++++++++++++++--------------
>  2 files changed, 64 insertions(+), 32 deletions(-)
> 
> diff --git a/drivers/edac/edac_core.h b/drivers/edac/edac_core.h
> index d035ee9..f84da6e 100644
> --- a/drivers/edac/edac_core.h
> +++ b/drivers/edac/edac_core.h
> @@ -341,23 +341,29 @@ struct csrow_info {
>  };
>  
>  struct mcidev_sysfs_group {
> -	const char *name;
> -	struct mcidev_sysfs_attribute *mcidev_attr;
> -	struct kobject kobj;
> +	const char *name;				/* group name */
> +	struct mcidev_sysfs_attribute *mcidev_attr;	/* group attributes */
> +};
> +
> +struct mcidev_sysfs_group_kobj {
> +	struct list_head list;		/* list for all instances within a mc */
> +
> +	struct kobject kobj;		/* kobj for the group */
>  
> +	struct mcidev_sysfs_group *grp;	/* group description table */
>  	struct mem_ctl_info *mci;	/* the parent */
>  };

I don't know which kernel you're patching here, but it doesn't look
anything like mine...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/