Re: USB serial regression 2.6.31.1 -> 2.6.31.2 [PATCH]

From: Greg KH
Date: Tue Oct 13 2009 - 22:35:26 EST


On Wed, Oct 14, 2009 at 10:30:06AM +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2009-10-13 at 10:03 -0400, Alan Stern wrote:
> > On Tue, 13 Oct 2009, Benjamin Herrenschmidt wrote:
> >
> > > usb-storage: Workaround devices with bogus sense size
> > >
> > > Some devices, such as Huawei E169, advertise more than the standard
> > > amount of sense data, causing us to set US_FL_SANE_SENSE, assuming
> > > they support it. However, they subsequently fail the request sense
> > > with that size.
> > >
> > > This works around it generically. When a sense request fails due to
> > > a device returning an error, US_FL_SANE_SENSE was set, and that sense
> > > request used a larger sense size, we retry with a smaller size before
> > > giving up.
> > >
> > > Based on an original patch by Ben Efros <ben@xxxxxxxxxxxxx>
> > >
> > > Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> >
> > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
>
> Cool. Who's going to commit it ? Greg ? Or should I send it to Linus ?

I will, I'll send it off tomorrow.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/