Re: [PATCH] pci: increase alignment to make more space for hidden code

From: Bjorn Helgaas
Date: Tue Oct 13 2009 - 11:16:19 EST


On Tuesday 13 October 2009 12:49:01 am Ingo Molnar wrote:
> * Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote:

> > In the patch below, I added some extra PCI dumps of the bridge and the
> > NIC around the ACPI EC init. The patch also removes Yinghai's
> > workaround so we should see the original failure, just with a little
> > more debug.
>
> Btw., i'd _strongly_ suggest to finally add some sort of pci=verbose
> easy-to-use debug toggle for users to enable.
>
> Everything that matters to resource allocation. We should print the BIOS
> state (Yinghai did a patch for this some time ago and that is upstream
> already), we should print quirk execution, we should print ACPI AML
> execution - everything that might matter to PCI allocations.
>
> An easy-to-use 'give me all the debug info' feature is really important.
> We have apic=verbose for similar reasons.

Agreed. That's why I sent such a huge testing patch -- I think we do
a poor job of making this stuff debuggable, so I want to use this problem
as a test case of "what useful stuff can we print to make this easier in
the future."

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/